Improve support for running HydePHP through the Phar archive #1491
+17
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
changed the title
caendesilva
changed the title
caendesilva
force-pushed
the
improve-phar-support
branch
from
89f84b2 to
68f8539
Compare
caendesilva
force-pushed
the
improve-phar-support
branch
from
3a9bed3 to
13c92b2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1491 +/- ##
=============================================
Coverage 100.00% 100.00%
- Complexity 1740 3480 +1740
=============================================
Files 180 360 +180
Lines 4715 9430 +4715
=============================================
+ Hits 4715 9430 +4715 ☔ View full report in Codecov by Sentry. |
This should resolve a lot of the issues we're having with the standalone, due to Phar paths being formatted like `'H:\monorepo/phar://foo'`, when they should be unchanged (`'phar://foo'`)
caendesilva
force-pushed
the
improve-phar-support
branch
from
161df62 to
f2350e3
Compare
Update dashboard to inject scripts directly from archive when running in Phar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
These will fix hydephp/cli#49, as well as other probable compatibility issues in that repo.
Update PharSupport vendor path method to support more packages
Removes the requirement that the vendor package is
frameworkand updates the resolver to handle other Hyde packages.Update path helper to not format Phar paths
This should resolve a lot of the issues we're having with the standalone, due to Phar paths being formatted like
'H:\monorepo/phar://foo', when they should be unchanged ('phar://foo')Update dashboard to load scripts from Phar
Update dashboard to inject scripts directly from archive when running in Phar